feat: Automate SIPNET binary builds and manual release #36
Conversation
There was a problem hiding this comment.
@AritraDey-Dev Thank you for the PR!
Do I read this correctly, that it will create a release and upload binaries on every PR push? That would be way to often; at most, it should be on merging with the master branch.
There was a problem hiding this comment.
Awesome, thanks for taking this on @AritraDey-Dev
Two requests (with what I think the code would look like):
- trigger on tags matching vX.Y.Z
on:
push:
tags:
- 'v*.*.*'
- create release as a draft
steps:
...
with:
...
draft: true
|
@dlebauer Thanks for the reviewing the PR.I will make those changes. |
Yes, you're correct. The current setup would trigger a release on every PR push. We should modify it to only create a release and upload binaries upon merging into the master branch. Thank you for pointing that out! |
|
It looks like .github/workflows/ci.yml includes steps to both upload SIPNET binaries using actions/upload-artifact and to create a release and upload binaries using action-gh-release and upload-release-asset. Just want to confirm - are these redundant? If so, is that intentional? |
This pull request fixes #27
CI Workflow Enhancements:
.github/workflows/ci.yml: Added a step to upload SIPNET binaries after the build step..github/workflows/ci.yml: Introduced a new job to create a release, which includes checking out the code, creating a release, and uploading the release asset.MakefileUpdates:Makefile: Added areleasetarget to thealltarget dependencies.Makefile: Defined thereleasetarget to package and compress the SIPNET binary and clean up the release directory.